Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add camera platform to tplink integration #129180

Merged
merged 36 commits into from
Dec 22, 2024
Merged

Add camera platform to tplink integration #129180

merged 36 commits into from
Dec 22, 2024

Conversation

sdb9696
Copy link
Contributor

@sdb9696 sdb9696 commented Oct 25, 2024 •
edited
Loading

Proposed change

Add the camera platform to tplink integration for Tapo cameras.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @rytilahti, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tplink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tplink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@rytilahti rytilahti added the waiting-for-upstream We're waiting for a change upstream label Oct 25, 2024
@a-w-1806
Copy link

Hey folks, I just bought a Tapo Camera and was looking into how to integrate it with HA. In case anyone missed it, this might be related: JurajNyiri/HomeAssistant-Tapo-Control#551

@sdb9696 sdb9696 mentioned this pull request Nov 27, 2024
Merged
8 tasks
@rytilahti rytilahti removed the waiting-for-upstream We're waiting for a change upstream label Nov 27, 2024
@sdb9696 sdb9696 marked this pull request as ready for review November 27, 2024 15:44
@bdraco bdraco added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Nov 27, 2024
rytilahti
rytilahti reviewed Nov 28, 2024
View reviewed changes
homeassistant/components/tplink/camera.py Outdated Show resolved Hide resolved
homeassistant/components/tplink/camera.py Outdated Show resolved Hide resolved
homeassistant/components/tplink/camera.py Outdated Show resolved Hide resolved
homeassistant/components/tplink/camera.py Outdated Show resolved Hide resolved
homeassistant/components/tplink/camera.py Outdated Show resolved Hide resolved
@sdb9696 sdb9696 requested a review from bdraco December 4, 2024 19:30
@rytilahti rytilahti mentioned this pull request Dec 9, 2024
Open
@sdb9696 sdb9696 mentioned this pull request Dec 10, 2024
Merged
19 tasks
@sdb9696 sdb9696 mentioned this pull request Dec 17, 2024
Open
@sdb9696
Copy link
Contributor Author

sdb9696 commented Dec 20, 2024

PR updated to use stream.async_check_stream_client_error and simplified some of the checking code at the same time. No longer uses ffmpeg directly to get an image but relies solely on the new checking method during config_flow.

Also enforces username and password for camera credentials as we now know that no creds doesn't really work as using the same creds for cloud and camera can be problematic.

rytilahti
rytilahti approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to go, great work @sdb9696! 🥇 Tested to work with TC65.

@rytilahti rytilahti changed the title Add camera entity to tplink integration Add camera platform to tplink integration Dec 22, 2024
@frenck frenck merged commit b1f6563 into home-assistant:dev Dec 22, 2024
34 checks passed
@sdb9696 sdb9696 deleted the tplink/feat/camera branch December 23, 2024 09:12
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rytilahti rytilahti rytilahti approved these changes

@bdraco bdraco bdraco approved these changes

Assignees

@bdraco bdraco

@rytilahti rytilahti

Labels
by-code-owner cla-signed Hacktoberfest integration: tplink new-feature new-platform noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: platinum
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sdb9696 @a-w-1806 @bdraco @rytilahti @frenck